linux-kernel - Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <000301cedb92$1fa1f920$5ee5eb60$%han@samsung.com>
Date:	Thu, 07 Nov 2013 17:19:48 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Brian Norris' <computersforpeace@...il.com>,
	"'Gupta, Pekon'" <pekon@...com>
Cc:	'Wei Yongjun' <weiyj.lk@...il.com>,
	'David Woodhouse' <dwmw2@...radead.org>,
	'Daniel Mack' <zonque@...il.com>, avinashphilip@...com,
	'Artem Bityutskiy' <artem.bityutskiy@...ux.intel.com>,
	tony@...mide.com, yongjun_wei@...ndmicro.com.cn,
	linux-mtd@...ts.infradead.org,
	'Linux Kernel' <linux-kernel@...r.kernel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH -next] mtd: nand: omap: fix error return code in
 omap_nand_probe()

On Thursday, November 07, 2013 4:19 PM, Brian Norris wrote:
> On Wed, Nov 06, 2013 at 06:06:25PM +0000, Pekon Gupta wrote:
> > > From: Brian Norris [mailto:computersforpeace@...il.com]
> > > > On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han <jg1.han@...sung.com>
> > > >> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > > >>
> > > >> Fix to return a negative error code from the error handling
> > > >> case instead of 0, as done elsewhere in this function.
> > > >
> > > > Commit message is right? :-(
> > >
> > > It sounds OK by my reading. Unless you're having trouble parsing what
> > > "as done elsewhere in this function" is being applied to. (IOW, is the
> > > rest of the function returning a negative error code on the error
> > > paths, or is it returning 0? Of course the answer is the former, but
> > > it's possible to misread it.) If it helps, I can try to tweak the
> > > wording a bit when applying this patch.
> > >
> > > Pekon, can I get an Acked-by?
> > >
> > Yes sure .. Sorry I was away from both mailbox and boards.
> 
> No problem.
> 
> > Acked-by: Pekon Gupta <pekon@...com>
> >
> > And thanks much Wei Yongjun for fixing this .
> 
> Thanks. Pushed to l2-mtd.git with a slight tweak in the description.

Hi Norris,

I checked the patch in l2-mtd.git.
The commit message looks good.
I understand what the patch means.
Thank you.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/