linux-kernel - Re: [patch 1/2] resources: clean up pnp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hk3gkvbiw.wl%tiwai@suse.de>
Date:	Thu, 07 Nov 2013 09:52:55 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
	Toshi Kani <toshi.kani@...com>, Ram Pai <linuxram@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] resources: clean up pnp_irq() error return

At Thu, 7 Nov 2013 11:17:49 +0300,
Dan Carpenter wrote:
> 
> pnp_irq() returns -1 on error but cast to an unsigned.  It is confusing
> for callers who assume that it returns a negative value.  I have
> introduced a new define IORESOURCE_INVALID which is the same value but
> hopefully it looks less like a negative value.

How about just returning int instead of resource_size_t?
IRQ numbers are handled by int in almost all drivers.


thanks,

Takashi

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 89b7c24..fdccfa5 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -55,6 +55,8 @@ struct resource {
>  #define IORESOURCE_AUTO		0x40000000
>  #define IORESOURCE_BUSY		0x80000000	/* Driver has marked this resource busy */
>  
> +#define IORESOURCE_INVALID	((resource_size_t)-1)
> +
>  /* PnP IRQ specific bits (IORESOURCE_BITS) */
>  #define IORESOURCE_IRQ_HIGHEDGE		(1<<0)
>  #define IORESOURCE_IRQ_LOWEDGE		(1<<1)
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index 195aafc..818669c 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -151,7 +151,7 @@ static inline resource_size_t pnp_irq(struct pnp_dev *dev, unsigned int bar)
>  
>  	if (pnp_resource_valid(res))
>  		return res->start;
> -	return -1;
> +	return IORESOURCE_INVALID;
>  }
>  
>  static inline unsigned long pnp_irq_flags(struct pnp_dev *dev, unsigned int bar)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/