linux-kernel - Re: [PATCH 1/2] clockevent: sun4i: Fill the irq field in the clockevent structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527B68B9.9060701@linaro.org>
Date:	Thu, 07 Nov 2013 11:17:29 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	tglx@...utronix.de
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	sboyd@...eaurora.org
Subject: Re: [PATCH 1/2] clockevent: sun4i: Fill the irq field in the clockevent
 structure

On 10/25/2013 01:16 PM, Maxime Ripard wrote:
> The clock event structure irq field was not filled previously to the
> interrupt we're using.
>
> This was resulting in the timer not being used at all when using a
> configuration with SMP enabled on a system with several CPUs, and with
> the cpumask set to the cpu_possible_mask.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Applied to my tree for 3.14

> ---
>   drivers/clocksource/sun4i_timer.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/sun4i_timer.c b/drivers/clocksource/sun4i_timer.c
> index 2fb4695..a7f492e 100644
> --- a/drivers/clocksource/sun4i_timer.c
> +++ b/drivers/clocksource/sun4i_timer.c
> @@ -188,6 +188,7 @@ static void __init sun4i_timer_init(struct device_node *node)
>   	writel(val | TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_EN_REG);
>
>   	sun4i_clockevent.cpumask = cpumask_of(0);
> +	sun4i_clockevent.irq = irq;
>
>   	clockevents_config_and_register(&sun4i_clockevent, rate,
>   					TIMER_SYNC_TICKS, 0xffffffff);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/