linux-kernel - Re: [PATCH v2] usb: gadget: f_mass_storage: call try_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1311071021560.1401-100000@iolanthe.rowland.org>
Date:	Thu, 7 Nov 2013 10:24:47 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	George Cherian <george.cherian@...com>
cc:	balbi@...com, <bigeasy@...utronix.de>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: gadget: f_mass_storage: call try_to_freeze only
 when its safe

On Thu, 7 Nov 2013, George Cherian wrote:

> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
> do_read() and do_write() calls sleep_thread with lock held.
> Make sure these wont call try_to_freeze() by passing can_freeze flag
> to sleep_thread.
> 
> Calling try_to_freeze() with a lock hold was done since day one in
> f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
> locks held at freeze time") lockdep complains about it.

Acked-by: Alan Stern <stern@...land.harvard.edu>

Although I would have preferred it if you spelled "it's" and "won't"  
with apostrophes in the first paragraph.  Without the apostrophes,
"its" is a possessive pronoun (meaning "something belonging to it")
and "wont" is a noun (meaning "habit").

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/