linux-kernel - Re: 答复：答复：[PATCH 2/4] perf tools: relate 'start' & 'end' to perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <527BB7E6.9060402@gmail.com>
Date:	Thu, 07 Nov 2013 08:55:18 -0700
From:	David Ahern <dsahern@...il.com>
To:	秦承刚 <chenggang.qcg@...baba-inc.com>,
	Chenggang Qin <chenggang.qin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Namhyung Kim <namhyung@...il.com>,
	Yanmin Zhang <yanmin.zhang@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Mike Galbraith <efault@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	秦承刚 <chenggang.qcg@...bao.com>
Subject: Re: 答复：答复：[PATCH 2/4] perf tools: relate 'start' & 'end' to perf_session

On 11/7/13, 5:14 AM, 秦承刚 wrote:
> Hi, David
> The samples for the task before the end of the time window are not
> influenced by the time window. The time window only cover the sample
> events in the ordered_samples. FORK, MMAP, COMM events are not in the
> ordered_samples. They are delivered in the function
> "perf_session__process_event". The task events that are after the end of
> the time window can be ingnored safely.

following builtin-report.c:
perf_session__process_events() -> __perf_session__process_events() --> 
perf_session__process_event():

     ret = perf_evlist__parse_sample(session->evlist, event, &sample);
     if (ret)
         return ret;

     if (tool->ordered_samples) {
         ret = perf_session_queue_event(session, event, &sample,
                            file_offset);
         if (ret != -ETIME)
             return ret;
     }

All samples are dropped into the ordered_samples queue if they have a 
timestamp. And I believe it was the sample_id_all patch that put a 
timestamp on task events too (~2.6.35 or 36 timeframe).


> Would you give me a link to your patch?

https://github.com/dsahern/linux/blob/timehist-timeofday-3.9/tools/perf/util/time-utils.c
and
https://github.com/dsahern/linux/blob/timehist-timeofday-3.9/tools/perf/builtin-timehist.c

I did not push the builtin-report.c change, but it follows directly from 
the timehist command.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/