linux-kernel - Re: [GIT PULL] uprobes: preparations for arm port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Nov 2013 17:27:36 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	David Long <dave.long@...aro.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] uprobes: preparations for arm port

On 11/07, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@...hat.com> wrote:
>
> > and we need to cleanup copy_insn()
> > first.

Heh. I never read it carefully, I always knew it should be cleanuped.

But when I looked at it now I realized that it is very wrong, and it
is very easy to crash the kernel (fortunately only root can enable
uprobes).

So we need to fix it (and cleanup), I'll try to make the patch asap.

> > For the moment, please ignore the patch which adds the new ->ixol
> > member.
>
> I didn't actually disagree with it so I pulled it

Thanks,

> - I was just wondering
> about those cleanliness details.

And you are right, this doesn't look clean. I should have mentioned
in the changelog that we need to (at least try) to cleanup this all.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/