[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXu5jJn3jJs+mB76ZxOu_ibXuo9Q3mVeKjruZsJRRKpuUJd3A@mail.gmail.com>
Date: Thu, 7 Nov 2013 09:26:45 -0800
From: Kees Cook <keescook@...omium.org>
To: James Hogan <james.hogan@...tec.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Andy Lutomirski <luto@...capital.net>,
Russell King - ARM Linux <linux@....linux.org.uk>,
Eric Paris <eparis@...hat.com>,
libseccomp-discuss@...ts.sourceforge.net,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Will Drewry <wad@...omium.org>,
Thomas Gleixner <tglx@...utronix.de>,
Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] seccomp: not compatible with ARM OABI
On Thu, Nov 7, 2013 at 2:59 AM, James Hogan <james.hogan@...tec.com> wrote:
> Hi,
>
> On 06/11/13 23:31, Kees Cook wrote:
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index af2cc6eabcc7..6eaca7d92399 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER
>>
>> config SECCOMP_FILTER
>> def_bool y
>> - depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET
>> + depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT
>
> Isn't this the whole point of HAVE_ARCH_SECCOMP_FILTER?
>
> Just change the select in arch/arm/Kconfig to this:
>
> select HAVE_ARCH_SECCOMP_FILTER if !OABI_COMPAT
Oh! Yeah, that's a much cleaner way to handle it. I totally forgot
that "select" could be conditional. I will respin it that way.
Thanks!
-Kees
--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists