linux-kernel - Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Nov 2013 11:57:57 -0800
From:	Tim Kryger <tim.kryger@...aro.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Christian Daudt <bcm@...thebug.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>,
	Grant Likely <grant.likely@...aro.org>,
	Device Tree List <devicetree@...r.kernel.org>,
	linux-doc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-i2c@...r.kernel.org,
	ARM Kernel List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

On Fri, Nov 1, 2013 at 6:08 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
> On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote:
>> Add support for I2C high-speed mode (3.4 MHz).
>>
>> Signed-off-by: Tim Kryger <tim.kryger@...aro.org>
>> Reviewed-by: Matt Porter <matt.porter@...aro.org>
>> Reviewed-by: Markus Mayer <markus.mayer@...aro.org>
>
> Mostly good as well:
>
>> +enum hs_bus_speed_index {
>> +     BCM_SPD_3P4MHZ = 0,
>> +};
>
> I just realized that you should update both patches to add the supported
> bus speeds to the binding documentation.

While the bus speed property is really a configuration parameter (and
not a true description of of the hardware) it seems improper to put
driver specific details into the binding document.

Please let me know how you would like me to proceed.

I should mention that I plan to break out the binding into its own
patch as this seems to be the latest best practice just in case that
influences your decision.

Thanks,
Tim Kryger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/