linux-kernel - Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h61s4dkqs.wl%tiwai@suse.de>
Date:	Thu, 07 Nov 2013 21:23:23 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	alsa-devel <alsa-devel@...a-project.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] hda_intel: ratelimit "spurious response" message

At Thu, 07 Nov 2013 11:55:15 -0800,
Joe Perches wrote:
> 
> dmesg here has a 100+ consecutive lines of:
> 
> [ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> [ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> [ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
> ...
> 
> Ratelimit the message to reduce the dmesg log noise.
> 
> Coalesce the format while at it.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks, applied.

BTW, which hardware shows this problem?
I'm interested rather in that...


Takashi

> ---
>  sound/pci/hda/hda_intel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 6e61a01..6e444ca 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -906,12 +906,12 @@ static void azx_update_rirb(struct azx *chip)
>  			chip->rirb.res[addr] = res;
>  			smp_wmb();
>  			chip->rirb.cmds[addr]--;
> -		} else
> -			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, "
> -				   "last cmd=%#08x\n",
> +		} else if (printk_ratelimit()) {
> +			snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n",
>  				   pci_name(chip->pci),
>  				   res, res_ex,
>  				   chip->last_cmd[addr]);
> +		}
>  	}
>  }
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/