linux-kernel - Re: [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131108104604.54366464@notabene.brown>
Date:	Fri, 8 Nov 2013 10:46:04 +1100
From:	NeilBrown <neilb@...e.de>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Grant Likely <grant.likely@...aro.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Belisko Marek <marek.belisko@...il.com>,
	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO
 configuration.

On Thu, 7 Nov 2013 15:39:00 -0800 Bryan Wu <cooloney@...il.com> wrote:

> On Thu, Oct 31, 2013 at 7:41 PM, NeilBrown <neilb@...e.de> wrote:
> >
> 
> [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO configuration.
> 
> I think it should be tca6507, right? Typo?

Obviously I'm still dreaming of the Apple IIe.  Yes, a typo.

> 
> For other parts of this patch, I'm OK for them.
> 
> And just a quick scan of the leds-tca6507, I found bunch of typos in
> the comments:
> 
> * An led-tca6507 device must be provided with platform data.  This data
>  * lists for each output: the name, default trigger, and whether the signal
>  * is being used as a GPiO rather than an led.  'struct led_plaform_data'
> 
> Can we unify to use GPIO and gpio?
> 
>  * is used for this.  If 'name' is NULL, the output isn't used.  If 'flags'
>  * is TCA6507_MAKE_CPIO, the output is a GPO.
> 
> Here should be TCA6507_MAKE_GPIO and GPIO instead of GPO
> 
>  * The "struct led_platform_data" can be embedded in a
>  * "struct tca6507_platform_data" which adds a 'gpio_base' for the GPiOs,
>  * and a 'setup' callback which is called once the GPiOs are available.
> 
> Don't use GPiO, please.
> 
> Could you please review the code again and submit a cleanup patch to
> fix those typos?

Yes, I'll send a patch shortly.

Thanks,
NeilBrown



Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)