linux-kernel - Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131107103607.53489c5d@xhacker>
Date:	Thu, 7 Nov 2013 10:36:07 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	Shawn Guo <shawn.guo@...aro.org>
CC:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: phy: phy-mxs-usb: set the correct platform drvdata

On Wed, 6 Nov 2013 18:34:47 -0800
Shawn Guo <shawn.guo@...aro.org> wrote:

> On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> > We need to set mxs_phy rather as the platform drvdata so that we can get
> > the correct mxs_phy in mxs_phy_remove().
> > 
> > Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
> > Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> 
> Acked-by: Shawn Guo <shawn.guo@...aro.org>
> 
> Change-Id should be dropped though.

OOPs, sorry, I should take care of that. I'll remind myself every time.

Thank you for your pointing out

Jisheng
> 
> Shawn
> 
> > ---
> >  drivers/usb/phy/phy-mxs-usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> > index fdd33b4..545844b 100644
> > --- a/drivers/usb/phy/phy-mxs-usb.c
> > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > @@ -164,7 +164,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
> >  
> >  	mxs_phy->clk = clk;
> >  
> > -	platform_set_drvdata(pdev, &mxs_phy->phy);
> > +	platform_set_drvdata(pdev, mxs_phy);
> >  
> >  	ret = usb_add_phy_dev(&mxs_phy->phy);
> >  	if (ret)
> > -- 
> > 1.8.4.2
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/