linux-kernel - Re: [patch] fat: double unlock on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjpfv5w3.fsf@devron.myhome.or.jp>
Date:	Fri, 08 Nov 2013 14:06:52 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [patch] fat: double unlock on error path

Dan Carpenter <dan.carpenter@...cle.com> writes:

> There is a stray unlock here which was not intended.  I have removed it.
>
> Fixes: 3f9f3dfb5755 ('fat: add fat_fallocate operation')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/fs/fat/file.c b/fs/fat/file.c
> index 03f716f..befedee 100644
> --- a/fs/fat/file.c
> +++ b/fs/fat/file.c
> @@ -257,10 +257,8 @@ static long fat_fallocate(struct file *file, int mode,
>  		goto error;
>  
>  	err = inode_newsize_ok(inode, (len + offset));
> -	if (err) {
> -		mutex_unlock(&inode->i_mutex);
> +	if (err)
>  		goto error;
> -	}
>  
>  	if (mode & FALLOC_FL_KEEP_SIZE) {
>  		/* First compute the number of clusters to be allocated */

Right. Namjae, please include this fix to patchset at next time.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/