linux-kernel - [PATCH] unlz4: always set an error return code on failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <527CBC7D020000780010117C@nat28.tlf.novell.com>
Date:	Fri, 08 Nov 2013 09:27:09 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<linux-kernel@...r.kernel.org>
Cc:	"Matthew Daley" <mattjd@...il.com>, <kyungsik.lee@....com>,
	<akpm@...ux-foundation.org>
Subject: [PATCH] unlz4: always set an error return code on failures

"ret", being set to -1 early on, gets cleared by the first invocation
of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence
subsequent failures wouldn't be noticed by the caller without setting
it back to -1 right after those calls.

Reported-by: Matthew Daley <mattjd@...il.com>
Signed-off-by: Jan Beulich <jbeulich@...e.com>
Cc: Kyungsik Lee <kyungsik.lee@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>

--- a/lib/decompress_unlz4.c
+++ b/lib/decompress_unlz4.c
@@ -141,6 +141,7 @@ STATIC inline int INIT unlz4(u8 *input, 
 			goto exit_2;
 		}
 
+		ret = -1;
 		if (flush && flush(outp, dest_len) != dest_len)
 			goto exit_2;
 		if (output)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/