linux-kernel - Re: [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131108102853.GV30901@lee--X1>
Date:	Fri, 8 Nov 2013 10:28:53 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, rob@...dley.net
Subject: Re: [PATCH 1/1] Documentation/mfd: Fix typos in s2mps11.txt

As this is only a trivial patch, I'll take it out the hands of the
already overloaded DT maintainers.

> Fixed trivial typos to improve readability.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  Documentation/devicetree/bindings/mfd/s2mps11.txt |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index c9332c6..0ff4e65 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -1,10 +1,10 @@
>  
>  * Samsung S2MPS11 Voltage and Current Regulator
>  
> -The Samsung S2MP211 is a multi-function device which includes voltage and
> +The Samsung S2MPS11 is a multi-function device which includes voltage and

Nice catch eagle-eye!

>  current regulators, RTC, charger controller and other sub-blocks. It is
> -interfaced to the host controller using a I2C interface. Each sub-block is
> -addressed by the host system using different I2C slave address.
> +interfaced to the host controller using an I2C interface. Each sub-block is
> +addressed by the host system using different I2C slave addresses.
>  
>  Required properties:
>  - compatible: Should be "samsung,s2mps11-pmic".
> @@ -43,7 +43,8 @@ sub-node should be of the format as listed below.
>  
>   BUCK[2/3/4/6] supports disabling ramp delay on hardware, so explictly
>   regulator-ramp-delay = <0> can be used for them to disable ramp delay.
> - In absence of regulator-ramp-delay property, default ramp delay will be used.
> + In the absence of regulator-ramp-delay property, default ramp delay will
> + be used.

So if we're being pertinacity here, your correction isn't much better.

s/of regulator-ramp-delay property,/of {the,an} regulator-ramp-delay property, the

or 

s/of regulator-ramp-delay property,/of regulator-ramp-delay, the

>  NOTE: Some BUCKs share the ramp rate setting i.e. same ramp value will be set
>  for a particular group of BUCKs. So provide same regulator-ramp-delay<value>.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/