linux-kernel - Re: [PATCH] x86: make reboot task only run on the appropriate processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527D0D50.6010607@zytor.com>
Date:	Fri, 08 Nov 2013 08:12:00 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Vivek Goyal <vgoyal@...hat.com>, Baoquan He <bhe@...hat.com>
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, akpm@...ux-foundation.org, davej@...oraproject.org,
	rmk+kernel@....linux.org.uk, chaowang@...hat.com,
	mwhitehe@...hat.com, kexec@...ts.infradead.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Robin Holt <robinmholt@...ux.com>,
	Robin Holt <robinmholt@...il.com>
Subject: Re: [PATCH] x86: make reboot task only run on the appropriate processor

On 11/08/2013 07:14 AM, Vivek Goyal wrote:
> 
> Hi Bao,
> 
> This patch fixes the issue for me too. I noticed that we have generic
> function migrate_to_reboot_cpu() to achieve what we want and rest of
> the reboot paths are using it. So how about using that function. I 
> wrote the new patch below. It works for me. Can you please give it
> a try.
> 
> Thanks
> Vivek
> 

Is this path exercised for the kdump flow?  migrate_to_reboot_cpu() is
unsafe in that case.

> Index: linux-2.6/kernel/kexec.c
> ===================================================================
> --- linux-2.6.orig/kernel/kexec.c	2013-10-16 00:30:50.000000000 -0400
> +++ linux-2.6/kernel/kexec.c	2013-11-08 21:34:02.492072375 -0500
> @@ -1676,6 +1676,7 @@ int kernel_kexec(void)
>  #endif
>  	{
>  		kernel_restart_prepare(NULL);
> +		migrate_to_reboot_cpu();
>  		printk(KERN_EMERG "Starting new kernel\n");
>  		machine_shutdown();
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/