linux-kernel - Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Nov 2013 10:04:08 -0800
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Michal Nazarewicz <mina86@...a86.com>
CC:	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>, gregkh@...uxfoundation.org,
	USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when
 not aligned to maxpacketsize

Hi Michal,

On 11/08/2013 04:23 AM, Michal Nazarewicz wrote:
> On Thu, Nov 07 2013, Alan Stern wrote:
>> What happens if the userspace daemon writes to epfile but the host
>> changes the config or altsetting before all the data can be sent?  Does
>> the remaining data get flushed?
>
> Each read and write is mapped to a single request, so the usual.
>
>> I'm still a little unclear on this.  Disabling the function ought to
>> have much the same effect as changing the config or altsetting: Writes
>> to endpoint files should be flushed and reads should be terminated.
>> Otherwise you would end up sending stale data to the host or reading
>> data that the daemon isn't prepared for.
>
> You may have a point here.  I'll try to prepare a patch over the weekend.

It looks like our patches are going to have dependence.
If you send yours this weekend, I'll wait to send new version of this
patch of mine on top of yours.

Br, David Cohen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/