linux-kernel - Re: [PATCH] regmap: Fix compile warning with value uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131109151626.GT2493@sirena.org.uk>
Date:	Sat, 9 Nov 2013 15:16:26 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Caizhiyong <caizhiyong@...ilicon.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wanglin (Albert)" <albert.wanglin@...ilicon.com>
Subject: Re: [PATCH] regmap: Fix compile warning with value uninitialized

On Sat, Nov 09, 2013 at 09:49:11AM +0000, Caizhiyong wrote:

> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs,
>  			  int num_regs)
>  {
>  	struct reg_default *p;
> -	int i, ret;
> +	int i;
> +	int ret = 0;
>  	bool bypass;

This sort of fix isn't ideal, it just silences the warning but if the
compiler has spotted a genuine oversight in the function it won't
address it.  It's better to include some analysis of why this is a good
fix.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)