linux-kernel - Re: [PATCH] regmap: Fix compile warning with value uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Nov 2013 08:15:13 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Levente Kurusa <levex@...ux.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Caizhiyong <caizhiyong@...ilicon.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Wanglin (Albert)" <albert.wanglin@...ilicon.com>
Subject: Re: [PATCH] regmap: Fix compile warning with value uninitialized

On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote:
> 2013-11-09 16:16 keltezéssel, Mark Brown írta:
> > On Sat, Nov 09, 2013 at 09:49:11AM +0000, Caizhiyong wrote:
> > 
> >> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs,
> >>  			  int num_regs)
> >>  {
> >>  	struct reg_default *p;
> >> -	int i, ret;
> >> +	int i;
> >> +	int ret = 0;
> >>  	bool bypass;
> Wouldn't the following be better?
> 
> int i, ret = 0;
> 
> I think it is more readable.

No, please put them on separate lines like the patch did.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/