linux-kernel - RE: [PATCH] misc: mic: dead code removal and minor cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6DC2528F945B4149AB6566DFB5F22ED38AAA142A@ORSMSX109.amr.corp.intel.com>
Date:	Sat, 9 Nov 2013 05:06:57 +0000
From:	"Dixit, Ashutosh" <ashutosh.dixit@...el.com>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	"Kharche, Harshavardhan R" <harshavardhan.r.kharche@...el.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"Rao, Nikhil" <nikhil.rao@...el.com>,
	"Dutt, Sudeep" <sudeep.dutt@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: mic: dead code removal and minor cleanup

> -----Original Message-----
> From: Michael Opdenacker [mailto:michael.opdenacker@...e-electrons.com]
> Sent: Friday, November 08, 2013 8:14 PM
> Subject: [PATCH] misc: mic: dead code removal and minor cleanup
> 
> This removes the below test in drivers/misc/mic/card/mic_virtio.c:
> 
> if (!retry) {
> ...
> }
> 
> This is dead code because the "retry" variable was set to 100
> earlier in the same function.
> 
> This also removes dev_dbg statements to print the value of this variable.
> That's not interesting to print the value of a variable which value is
> always the same.

Hi Michael,

Thanks for your mail. However, the dead code has resulted from
another bug in the code, we should be decrementing retry instead
of i. The same bug occurs in several other places in the code too.

So I would say don't apply this patch. We are planning a series of
patches to fix other issues in the code when the 3.13 merge window
closes and will include this fix too and include you in "Reported-by".

Thanks,
Ashutosh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/