linux-kernel - Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11439632.EJeOOmBkrd@flatron>
Date:	Sun, 10 Nov 2013 19:15:21 +0100
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	kgene.kim@...sung.com, t.figa@...sung.com,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
	rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com,
	swarren@...dotorg.org, ijc+devicetree@...lion.org.uk,
	linux@....linux.org.uk, Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCHv3 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

Hi Chanwoo, Marek,

On Monday 04 of November 2013 10:56:00 Chanwoo Choi wrote:
> From: Marek Szyprowski <m.szyprowski@...sung.com>
> 

No patch description?

> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3081bae..d7a3fbc 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -43,6 +43,8 @@
>  		interrupt-parent = <&mct_map>;
>  		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
>  			     <4 0>, <5 0>;
> +		clocks = <&clock 3>, <&clock 344>;
> +		clock-names = "fin_pll", "mct";
>  
>  		mct_map: mct-map {
>  			#interrupt-cells = <2>;
> 

Otherwise the patch is technically correct, but I have already sent
a series[1] that moves MCT node one level up to exynos4x12.dtsi, which
also solves this problem.

[1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207/focus=22208

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/