[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 11 Nov 2013 12:53:07 +0100
From: Ingo Molnar <mingo@...nel.org>
To: David Ahern <dsahern@...il.com>
Cc: acme@...stprotocols.net, linux-kernel@...r.kernel.org,
jolsa@...hat.com, Frederic Weisbecker <fweisbec@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
Namhyung Kim <namhyung@...nel.org>,
Mike Galbraith <efault@....de>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 4/4] perf record: mmap output file - v3
* David Ahern <dsahern@...il.com> wrote:
> >>+do_mmap:
> >>+ offset = rec->session->header.data_offset + rec->bytes_written;
> >>+ if (offset < (ssize_t) rec->mmap_out_size) {
> >>+ rec->mmap_offset = offset;
> >>+ offset = 0;
> >>+ } else
> >>+ rec->mmap_offset = 0;
> >
> >(Nit: unbalanced curly braces.)
>
> I believe checkpatch.pl complains, but will add.
Hm, if that is so then please report that to the checkpatch folks, the
warning is bogus and causes worse code to be written.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists