linux-kernel - [tip:x86/mce] ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 09:51:47 -0800
From:	"tip-bot for Luck, Tony" <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	tony.luck@...el.com, gong.chen@...ux.intel.com, tglx@...utronix.de,
	rjw@...ysocki.net, fengguang.wu@...el.com
Subject: [tip:x86/mce] ACPI, x86:
  Fix extended error log driver to depend on CONFIG_X86_LOCAL_APIC

Commit-ID:  9ebddac7ea2a1f4b4ce3335a78312a58dfaadb4d
Gitweb:     http://git.kernel.org/tip/9ebddac7ea2a1f4b4ce3335a78312a58dfaadb4d
Author:     Luck, Tony <tony.luck@...el.com>
AuthorDate: Fri, 8 Nov 2013 14:03:33 -0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 11 Nov 2013 10:21:29 +0100

ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCAL_APIC

Randconfig build by Fengguang's robot army reported:

   drivers/built-in.o: In function `extlog_print':
   >> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'

The config had CONFIG_SMP=n so we picked up this definition from:

  <asm/cpu.h>: #define cpu_physical_id(cpu) boot_cpu_physical_apicid

But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y.

Reported-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Tony Luck <tony.luck@...el.com>
Cc: Chen Gong <gong.chen@...ux.intel.com>
Cc: Rafael J. Wysocki <rjw@...ysocki.net>
Link: http://lkml.kernel.org/r/6be3afdcad7968f7fb7c0b681e547b3e872e44dd.1383947368.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 08eadb4..e11faae 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"
 
 config ACPI_EXTLOG
 	tristate "Extended Error Log support"
-	depends on X86_MCE
+	depends on X86_MCE && X86_LOCAL_APIC
 	select EFI
 	select UEFI_CPER
 	default n
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/