lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 11 Nov 2013 22:13:43 +0100
From:	Michal Nazarewicz <mina86@...a86.com>
To:	David Cohen <david.a.cohen@...ux.intel.com>
Cc:	Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function

> On 11/10/2013 08:50 AM, Michal Nazarewicz wrote:
>> +		if (wait_event_interruptible(epfile->wait, (ep = epfile->ep))) {

On Mon, Nov 11 2013, David Cohen wrote:
> FYI this line fails checkpatch:
> ERROR: do not use assignment in if condition
> #70: FILE: drivers/usb/gadget/f_fs.c:777:
> +		if (wait_event_interruptible(epfile->wait, (ep = epfile->ep))) {
>
> total: 1 errors, 0 warnings, 121 lines checked

This is intentional.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--


Download attachment "signature.asc" of type "application/pgp-signature" (836 bytes)

Powered by blists - more mailing lists