linux-kernel - Re: [GIT PULL] x86/boot changes for v3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 13:37:48 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/boot changes for v3.13

On Mon, Nov 11, 2013 at 9:05 AM, Ingo Molnar <mingo@...nel.org> wrote:

> Two changes that prettify and compactify the SMP bootup output from:
>
>  [    0.371169] smpboot: Booting Node   0, Processors  #1 #2 #3 OK
>  [    0.417339] smpboot: Booting Node   1, Processors  #4 #5 #6 #7 OK
>  [    0.554805] smpboot: Booting Node   2, Processors  #8 #9 #10 #11 OK
>  [    0.692323] smpboot: Booting Node   3, Processors  #12 #13 #14 #15 OK
>  [    0.829039] Brought up 16 CPUs
>
> to something like:
>
> [    0.379167] x86: Booting SMP configuration:
> [    0.383506] .... node  #0, CPUs:        #1  #2  #3
> [    0.429207] .... node  #1, CPUs:    #4  #5  #6  #7
> [    0.565353] .... node  #2, CPUs:    #8  #9 #10 #11
> [    0.701898] .... node  #3, CPUs:   #12 #13 #14 #15
> [    0.837695] x86: Booted up 4 nodes, 16 CPUs
>
...
>         if (system_state == SYSTEM_BOOTING) {
>                 if (node != current_node) {
>                         if (current_node > (-1))
> -                               pr_cont(" OK\n");
> +                               pr_cont("\n");
>                         current_node = node;
> -                       pr_info("Booting Node %3d, Processors ", node);
> +
> +                       printk(KERN_INFO ".... node %*s#%d, CPUs:  ",
> +                              node_width - num_digits(node), " ", node);
>                 }
> -               pr_cont(" #%4d%s", cpu, cpu == max_cpu_present ? " OK\n" : "");
> -               return;
> +
> +               /* Add padding for the BSP */
> +               if (cpu == 1)
> +                       pr_cont("%*s", width + 1, " ");

How do you know CPU0 and CPU1 are in same package?

> +
> +               pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu);
> +
>         } else
>                 pr_info("Booting Node %d Processor %d APIC 0x%x\n",
>                         node, cpu, apicid);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/