linux-kernel - Re: [patch] mailbox/omap: make mbox->irq signed for error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 17:07:59 -0600
From:	Suman Anna <s-anna@...com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Omar Ramirez Luna <omar.ramirez@...itl.com>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
	<tony@...mide.com>
Subject: Re: [patch] mailbox/omap: make mbox->irq signed for error handling


On 11/07/2013 01:49 AM, Dan Carpenter wrote:
> There is a bug in omap2_mbox_probe() where we try do:
>
> 		mbox->irq = platform_get_irq(pdev, info->irq_id);
> 		if (mbox->irq < 0) {
>
> The problem is that mbox->irq is unsigned so the error handling doesn't
> work.  I've changed it to a signed integer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

LGTM, thanks for the fix.

regards
Suman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/