linux-kernel - Re: [PATCH] drivers: replace IS_ERR and PTR_ERR with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 15:43:10 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	duanj.fnst@...fujitsu.com
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

On 11/01/2013 06:09 PM, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
> ---
>  drivers/misc/carma/carma-fpga.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/misc/carma/carma-fpga.c b/drivers/misc/carma/carma-fpga.c
> index 08b18f3..9a32e98 100644
> --- a/drivers/misc/carma/carma-fpga.c
> +++ b/drivers/misc/carma/carma-fpga.c
> @@ -956,10 +956,7 @@ static int data_debugfs_init(struct fpga_device *priv)
>  {
>  	priv->dbg_entry = debugfs_create_file(drv_name, S_IRUGO, NULL, priv,
>  					      &data_debug_fops);
> -	if (IS_ERR(priv->dbg_entry))
> -		return PTR_ERR(priv->dbg_entry);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(priv->dbg_entry);
>  }

Those code has make sure that CONFIG_DEBUG_FS is enabled, so
debugfs_create_file() never return PTR_ERR(), only NULL will
be returned when error occurs.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/