linux-kernel - Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131112001540.GA26611@kroah.com>
Date:	Mon, 11 Nov 2013 16:15:40 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Conrad Gomes <conrad.s.j.gomes@...il.com>
Cc:	abbotti@....co.uk, hsweeten@...ionengravers.com, joe@...ches.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issues in unioxx5.c

On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote:
> This is a patch which fixes  coding style issues in unioxx5.c found
> by checkpatch.pl
> 
> 1) Replaced printk with pr_info and pr_err

Drivers should never call printk() as they all have access to a struct
device somewhere.  So please call dev_info() or dev_err() instead.

> 2) Reinitialized n_subd before for loop to fix over 80 character
>    warning
> 3) Reworded comment to fix 80 character warning
>

Patches should do one thing, not 3 things.  Care to break this up into
"one logical change per patch"?  Yes, it's a small thing, but if you had
done this already, I could have taken the other 2 patches and you would
have just had to redo one patch in this series...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/