linux-kernel - Re: [GIT PULL] x86/boot changes for v3.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131112112338.GA12801@gmail.com>
Date:	Tue, 12 Nov 2013 12:23:38 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/boot changes for v3.13

* Borislav Petkov <bp@...en8.de> wrote:

> On Mon, Nov 11, 2013 at 01:37:48PM -0800, Yinghai Lu wrote:
> > How do you know CPU0 and CPU1 are in same package?
> 
> Why is that relevant?

So I suspect what Yinghai tried to say if CPU0 and CPU1 are not on the 
same node we do the printout incorrectly.

Arguably this was a pre-existing condition, but would be nice to fix it 
now that this code has emerged out of steady bitrot! :-)

How difficult would it be in your opinion? I think the best way to go 
about it would be to include CPU#0 in the list - I don't think anyone will 
be confused by the fact that it has already booted. That way the 'gap' for 
CPU#0 would be eliminated. Or something like that.

Btw., while staring at that code once more I noticed the following small 
nit, there's a pre-existing weird way of writing the -1 literal:

                          if (current_node > (-1))

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/