linux-kernel - Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131112213114.GB14439@danjae>
Date:	Tue, 12 Nov 2013 21:31:14 +0000
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Pekka Enberg <penberg@...nel.org>
Subject: Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

On Tue, Nov 12, 2013 at 09:15:08AM -0300, Arnaldo Carvalho de Melo wrote:
> Second part, just rewrote the changelog a bit:
> 
> commit 4e8a6e566fc611b9cbec2978a52266f29cb65785
> Author: Namhyung Kim <namhyung.kim@....com>
> Date:   Tue Nov 12 15:25:00 2013 +0900
> 
>     perf trace: Fix segfault on perf trace -i perf.data
>     
>     When replaying a previous record session, it'll get a segfault since it
>     doesn't initialize raw_syscalls enter/exit tracepoint's evsel->priv for
>     caching the format fields.
>     
>     So fix it by properly initializing sys_enter/exit evsels that comes from
>     reading the perf.data file header.

Looks good to me!

Thanks for doing this, Arnaldo.  I'll try to avoid this kind of thing
again in the future.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/