linux-kernel - Re: [PATCH] perf record: Delete file if a failure occurs writing the perf data file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131112150410.GW5056@laptop.programming.kicks-ass.net>
Date:	Tue, 12 Nov 2013 16:04:10 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Ingo Molnar <mingo@...nel.org>, acme@...stprotocols.net,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mike Galbraith <efault@....de>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf record: Delete file if a failure occurs writing the
 perf data file

On Tue, Nov 12, 2013 at 07:51:16AM -0700, David Ahern wrote:
> > From man mmap:
> >        SIGBUS Attempted access to a portion of the buffer that
> >        does not correspond  to  the  file (for  example, beyond
> >        the end of the file, ...

SIGBUS is basically the std fail for any fault; there's a ton more
reasons than listed in that manpage.

Failing to dirty a page due to -ENOSPACE is one reason we'll
trigger SIGBUS -- as you already found in that memcpy to mmap() instead
of write() patch.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/