Message-ID: <CA+5PVA5YJKDkNAqXXOSyDN5v+gTc7ig_kkJxCG6yhe8v2_SU2w@mail.gmail.com>
Date:	Tue, 12 Nov 2013 10:13:54 -0500
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Philipp Zabel <p.zabel@...gutronix.de>,
	Dave Airlie <airlied@...il.com>, devel@...verdev.osuosl.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: imx-drm/ipuv3-crtc.ko fails to link

On Tue, Nov 12, 2013 at 9:57 AM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> Hi Josh,
>
> On Tue, Nov 12, 2013 at 09:32:08AM -0500, Josh Boyer wrote:
>> On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer <jwboyer@...oraproject.org> wrote:
>> > Hi All,
>> >
>> > With v3.12-2839-gedae583 (Linus' tree as of this morning), the
>> > ipuv3-crtc.ko module fails to link with the following messages:
>> >
>> > ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_irq" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_get_resources"
>> > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_init" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_mode_set" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_set_base" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > ERROR: "ipu_plane_put_resources"
>> > [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>> > make[1]: *** [__modpost] Error 1
>> > make: *** [modules] Error 2
>>
>> Actually, I think this is because ipuv3-plane.c was added to the
>> Makefile as a requisite file for ipuv3-crtc.ko with commit
>> b8d181e408af6a017d, but Kbuild isn't interpreting it that way because
>> it's a tristate option, not a bool.  Making it work would require
>> something like:
>>
>> imx-ipuv3-crct-objs  := ipuv3-crtc.o ipuv3-plane.o
>> obj-$(CONFIG_DRM_IMX_IPUV3)  += imx-ipuv3-crct.o
>>
>> But that would rename the module from ipuv3-crtc.ko to
>> imx-ipuv3-crct.ko.  Even with that, it still fails to link with:
>>
>> ERROR: "imx_drm_crtc_id" [drivers/staging/imx-drm/imx-ipuv3-crtc.ko] undefined!
>>
>> So two questions really.
>>
>> 1) Are the tristate options for DRM_IMX_IPUV3, DRM_IMX_IPUV3_CORE,
>> DRM_IMX_LDB, DRM_IMX_TVE, DRM_IMX_PARALLEL_DISPLAY, and
>> DRM_IMX_FB_HELPER really all supposed to be separate modules, or
>> should they be boolean options to the main DRM_IMX tristate?
>
> I think at least the ipuv3 core should be a separate module since this
> could be used without drm support (for the input pathes, handled via v4l2)
>
>>
>> 2) If the answer to question 1 is "all separate modules", then either
>> ipuv3-crtc.c needs to be renamed or the final module name will be
>> different.
>
> The final module name shouldn't matter, we can change it.

OK.

> Does a EXPORT_SYMBOL_GPL(imx_drm_crtc_id) help fixing the problem?

I'm sure it would.  Haven't had a chance to test it yet.  Since the
module name change isn't a big deal, I'll see if I can come up with a
patch to fix the Makefile and linking issues and send that out.

>> And did anyone actually try building all of these as modules?  This
>> used to work in 3.12, but I'm not sure that was actually tested there
>> either.
>
> At least I explicitly made this work when writing the IPU stuff, but I
> must admit that we mostly use monolithic kernels here.

I figured as much.  Fedora builds them as modules, presumably because
we build multiboard kernels and building this in doesn't benefit
everything those run on.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists