[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1384271045.4771.47.camel@joe-AO722>
Date: Tue, 12 Nov 2013 07:44:05 -0800
From: Joe Perches <joe@...ches.com>
To: Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc: Andy Whitcroft <apw@...onical.com>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: scripts: checkpatch.pl & Lindent (minor complaint)
On Tue, 2013-11-12 at 09:42 -0500, Mimi Zohar wrote:
> scripts/Lindent and scripts/checkpatch disagree whether the fields in a
> statically initialized array should be blank separated.
>
> static struct ima_rule_entry default_rules[] = {
> {.action = DONT_MEASURE,.fsmagic = PROC_SUPER_MAGIC,.flags = IMA_FSMAGIC},
>
> Lindent adds a blank before '.fsmagic', which checkpatch then complains
> about (eg. commit 75834fc3).
Perhaps I don't understand what you mean.
Lindent _doesn't_add a blank and checkpatch
seems to do the right thing here.
I'd just as soon delete Lindent.
$ git log --format=email -p -1 75834fc3 | ./scripts/checkpatch.pl -
WARNING: line over 80 characters
#35: FILE: security/integrity/ima/ima_policy.c:52:
+ {.action = DONT_MEASURE,.fsmagic = PROC_SUPER_MAGIC,.flags = IMA_FSMAGIC},
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: security/integrity/ima/ima_policy.c:52:
+ {.action = DONT_MEASURE,.fsmagic = PROC_SUPER_MAGIC,.flags = IMA_FSMAGIC},
^
[...]
$ ./scripts/Lindent security/integrity/ima/ima_policy.c
$ git diff security/integrity/ima/ima_policy.c | ./scripts/checkpatch.pl -
ERROR: space required after that ',' (ctx:VxV)
#10: FILE: security/integrity/ima/ima_policy.c:72:
+ {.action = DONT_MEASURE,.fsmagic = PROC_SUPER_MAGIC,.flags =
^
ERROR: space required after that ',' (ctx:VxV)
#10: FILE: security/integrity/ima/ima_policy.c:72:
+ {.action = DONT_MEASURE,.fsmagic = PROC_SUPER_MAGIC,.flags =
^
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists