linux-kernel - Re: [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52824E28.8090102@gmail.com>
Date:	Tue, 12 Nov 2013 08:50:00 -0700
From:	David Ahern <dsahern@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as
 fd

On 11/11/13, 11:24 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
>
> The fifth argument of mmap syscall is fd and it often contains -1 as a
> value for anon mappings.  Without this patch it doesn't show the file
> name as well as it shows -1 as 4294967295.
>
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>   tools/perf/builtin-trace.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index c3008b1c369c..aeb6296a76bd 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -951,7 +951,8 @@ static struct syscall_fmt {
>   	{ .name	    = "mmap",	    .hexret = true,
>   	  .arg_scnprintf = { [0] = SCA_HEX,	  /* addr */
>   			     [2] = SCA_MMAP_PROT, /* prot */
> -			     [3] = SCA_MMAP_FLAGS, /* flags */ }, },
> +			     [3] = SCA_MMAP_FLAGS, /* flags */
> +			     [4] = SCA_FD, 	  /* fd */ }, },
>   	{ .name	    = "mprotect",   .errmsg = true,
>   	  .arg_scnprintf = { [0] = SCA_HEX, /* start */
>   			     [2] = SCA_MMAP_PROT, /* prot */ }, },
>

Looks good to me.

Acked-by: David Ahern <dsahern@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/