linux-kernel - Re: [PATCH] ALSA: pcm: retrieve true appl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5heh6ld1mo.wl%tiwai@suse.de>
Date:	Tue, 12 Nov 2013 17:29:51 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Oskar Schirmer" <oskar@...ra.com>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ALSA: pcm: retrieve true appl_ptr where stream was unlocked

At 12 Nov 2013 16:14:17 +0000,
Oskar Schirmer wrote:
> 
> Calculated for data transfer, the local variable appl_ptr is reused,
> changed and written back later, though the lock was not held during
> the transfer earlier. Admitted, destiny of the lock is not obvious
> at all, but this looks much like a race condition candidate, so make
> sure to have some original appl_ptr value to work on.

No, appl_ptr doesn't have to be re-read at that point.  Otherwise the
value will become inconsistent.

This is the write operation to a stream and it's exclusive.  The lock
is needed to protect the PCM state change (e.g. stopped from an irq
handler).


thanks,

Takashi

> 
> Two occurences.
> 
> Signed-off-by: Oskar Schirmer <oskar@...ra.com>
> ---
>  sound/core/pcm_lib.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index 6e03b46..47e836a 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -2051,6 +2051,7 @@ static snd_pcm_sframes_t snd_pcm_lib_write1(struct snd_pcm_substream *substream,
>  		default:
>  			break;
>  		}
> +		appl_ptr = runtime->control->appl_ptr;
>  		appl_ptr += frames;
>  		if (appl_ptr >= runtime->boundary)
>  			appl_ptr -= runtime->boundary;
> @@ -2283,6 +2284,7 @@ static snd_pcm_sframes_t snd_pcm_lib_read1(struct snd_pcm_substream *substream,
>  		default:
>  			break;
>  		}
> +		appl_ptr = runtime->control->appl_ptr;
>  		appl_ptr += frames;
>  		if (appl_ptr >= runtime->boundary)
>  			appl_ptr -= runtime->boundary;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/