linux-kernel - Re: [PATCH 01/14] sched: add sched_class->task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52826B28.2050208@gmail.com>
Date:	Tue, 12 Nov 2013 18:53:44 +0100
From:	Juri Lelli <juri.lelli@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	peterz@...radead.org, tglx@...utronix.de, mingo@...hat.com,
	oleg@...hat.com, fweisbec@...il.com, darren@...art.com,
	johan.eker@...csson.com, p.faure@...tech.ch,
	linux-kernel@...r.kernel.org, claudio@...dence.eu.com,
	michael@...rulasolutions.com, fchecconi@...il.com,
	tommaso.cucinotta@...up.it, nicola.manica@...i.unitn.it,
	luca.abeni@...tn.it, dhaval.giani@...il.com, hgu1972@...il.com,
	paulmck@...ux.vnet.ibm.com, raistlin@...ux.it,
	insop.song@...il.com, liming.wang@...driver.com, jkacur@...hat.com,
	harald.gustafsson@...csson.com, vincent.guittot@...aro.org,
	bruce.ashfield@...driver.com
Subject: Re: [PATCH 01/14] sched: add sched_class->task_dead.

On 11/12/2013 06:19 PM, Steven Rostedt wrote:
> On Thu,  7 Nov 2013 14:43:35 +0100
> Juri Lelli <juri.lelli@...il.com> wrote:
> 
>> From: Dario Faggioli <raistlin@...ux.it>
>>
>> Add a new function to the scheduling class interface. It is called
>> at the end of a context switch, if the prev task is in TASK_DEAD state.
>>
>> It might be useful for the scheduling classes that want to be notified
>> when one of their task dies, e.g. to perform some cleanup actions.
> 
> Nit.  s/task/tasks/
>

Amended, thanks!

Best,

- Juri

>>
>> Signed-off-by: Dario Faggioli <raistlin@...ux.it>
>> Signed-off-by: Juri Lelli <juri.lelli@...il.com>
>> ---
>>  kernel/sched/core.c  |    3 +++
>>  kernel/sched/sched.h |    1 +
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 5ac63c9..850a02c 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -1890,6 +1890,9 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev)
>>  	if (mm)
>>  		mmdrop(mm);
>>  	if (unlikely(prev_state == TASK_DEAD)) {
>> +		if (prev->sched_class->task_dead)
>> +			prev->sched_class->task_dead(prev);
>> +
>>  		/*
>>  		 * Remove function-return probe instances associated with this
>>  		 * task and put them back on the free list.
>> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>> index b3c5653..64eda5c 100644
>> --- a/kernel/sched/sched.h
>> +++ b/kernel/sched/sched.h
>> @@ -992,6 +992,7 @@ struct sched_class {
>>  	void (*set_curr_task) (struct rq *rq);
>>  	void (*task_tick) (struct rq *rq, struct task_struct *p, int queued);
>>  	void (*task_fork) (struct task_struct *p);
>> +	void (*task_dead) (struct task_struct *p);
>>  
>>  	void (*switched_from) (struct rq *this_rq, struct task_struct *task);
>>  	void (*switched_to) (struct rq *this_rq, struct task_struct *task);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/