linux-kernel - Re: [PATCH 09/17] [m68k] IRQ: add handle_polled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1d531dbddb96cdcb0dfbc1183ee6d443@gmail.com>
Date:	Wed, 13 Nov 2013 20:57:23 +1300
From:	Michael Schmitz <schmitzmic@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

Thomas,

>> I suppose setting the flag can be done in the corresponding irq 
>> startup
>> function, instead of when setting up the irq controller?
>
> irq_startup() is called with irq_desc->lock held and
> irq_set_status_flags() wants desc->lock as well. Deadlock

Thanks, point taken.

> And no, you don't want to fiddle manually in the irq descriptor data
> fields. See commit a6967caf00eb :)

I'm not that crazy :-)

>
>> Geert - I will send the patch to ataints.c implementing this as soon 
>> as
>> Thomas' fix is merged.
>
> I'll expedite it for 3.13.

Thanks, that'll help.

Cheers,

	Michael


>
> Thanks,
>
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" 
> in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/