linux-kernel - Re: [PATCHv3 0/8] omap hwspinlock dt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Nov 2013 09:36:22 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	"Anna, Suman" <s-anna@...com>
Cc:	Ohad Ben-Cohen <ohad@...ery.com>, Tony Lindgren <tony@...mide.com>,
	Benoit Cousson <bcousson@...libre.com>,
	Kumar Gala <galak@...eaurora.org>,
	Paul Walmsley <paul@...an.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCHv3 0/8]  omap hwspinlock dt support

On Tue, Nov 12, 2013 at 06:16:42PM +0000, Anna, Suman wrote:
> 
> > Hi,
> >
> > This is an updated series addressing the review comments from the
> > v2 series. The hwmod patches have been dropped from the repost
> > as per Paul's request, they have already been queued.
> 
> Mark,

Hi Suman,

> 
> Any comments on this series? Tony has picked up the OMAP DTS patches for 
> 3.13, and so
> the "ti,omap4-hwspinlock" compatible string is showing up as 
> undocumented in linux-next.
> How do you want me to proceed here? I will be separating out the 
> bindings into separate patches
> in the future.

The only thing I note that I'm not so keen on is that the
hwlock-specifier is always one cell, rather than using a #hwlock-cells
property on the provider (even if we required it to be <1> for the
moment and just failed if it wasn't).

If possible, I would like an amendment to always use #hwlock-cells, but
otherwise this looks fine to me. Feel free to add my Ack:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/