linux-kernel - Re: [PATCH 0/3] Bring SFI support to out-of-tree driver modules on Intel Mid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131113111934.GB9654@gmail.com>
Date:	Wed, 13 Nov 2013 12:19:34 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	David Cohen <david.a.cohen@...ux.intel.com>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, lenb@...nel.org
Subject: Re: [PATCH 0/3] Bring SFI support to out-of-tree driver modules on
 Intel Mid


* Christoph Hellwig <hch@...radead.org> wrote:

> On Tue, Nov 12, 2013 at 02:13:37PM -0800, David Cohen wrote:
>
> > Hi,
> > 
> > This patchset extends sfi_device() macro support to driver modules. 
> > The main use case is to allow external driver modules to be enumerated 
> > by SFI on Intel Mid platforms.
> 
> How about you merge those module again?  Remember code added to the 
> kernel without users isn't testable, and out of tree modules do not 
> bring us any value add.

I wanted to make the exact same point.

I recently had to revert a similarly misguided attempt which added bloat 
for out of tree modules without merging it in tree, see commit 
b5dfcb09debc ("Revert "x86/UV: Add uvtrace support").

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/