linux-kernel - Re: [PATCH 1/2] sched/mm: add finish_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131113124913.005fcfe5@mschwide>
Date:	Wed, 13 Nov 2013 12:49:13 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH 1/2] sched/mm: add finish_switch_mm function

On Wed, 13 Nov 2013 12:41:43 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, Nov 13, 2013 at 09:16:13AM +0100, Martin Schwidefsky wrote:
> > The switch_mm function is called with the task_lock and/or with
> > request queue lock. Add finish_switch_mm to allow an architecture
> > to execute some code after the mm has been switched but without
> > any locks held. One use case is the s390 architecture which will
> > use this to wait for the completion of TLB flush operations.
> 
> This so reminds me of what finish_arch_post_lock_switch() was supposed
> to do. See commit: 01f23e1630d9 ("sched/arch: Introduce the
> finish_arch_post_lock_switch() scheduler callback").
> 
> Now you hook into more places; but maybe you can Catalin can come up
> with something you both can use?

finish_task_switch() has the call to finish_arch_post_lock_switch(), but
idle_task_exit() and use_mm() do not have the call. If it is safe to add
finish_arch_post_lock_switch() there as well I could use it for s390.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/