linux-kernel - Re: [PATCH] svcrpc: remove the unnecessary evaluation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131113155658.GH28033@fieldses.org>
Date:	Wed, 13 Nov 2013 10:56:58 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Weng Meiling <wengmeiling.weng@...wei.com>
Cc:	linux-nfs@...r.kernel.org, Trond.Myklebust@...app.com,
	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH] svcrpc: remove the unnecessary evaluation

On Fri, Nov 08, 2013 at 03:23:12PM +0800, Weng Meiling wrote:
> 
> From: Weng Meiling <wengmeiling.weng@...wei.com>

Huh.  Looks like that was introduced with "[PATCH] knfsd: make sure
svc_process call the correct pg_authenticate for multi-service port" in
2005.  OK!  Applied.

--b.

> 
> Signed-off-by: Weng Meiling <wengmeiling.weng@...wei.com>
> ---
>  net/sunrpc/svc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index b974571..e7fbe36 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -1104,8 +1104,6 @@ svc_process_common(struct svc_rqst *rqstp, struct kvec *argv, struct kvec *resv)
>  	rqstp->rq_vers = vers = svc_getnl(argv);	/* version number */
>  	rqstp->rq_proc = proc = svc_getnl(argv);	/* procedure number */
> 
> -	progp = serv->sv_program;
> -
>  	for (progp = serv->sv_program; progp; progp = progp->pg_next)
>  		if (prog == progp->pg_prog)
>  			break;
> -- 
> 1.8.3.1
> 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/