linux-kernel - Re: [PATCH] dma-debug: enhance dma_debug_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Nov 2013 16:22:24 -0800
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	shuah.kh@...sung.com
CC:	akpm@...ux-foundation.org, joro@...tes.org,
	linux-kernel@...r.kernel.org, shuahkhan@...il.com
Subject: Re: [PATCH] dma-debug: enhance dma_debug_device_change() to check
 for mapping errors

On 11/12/2013 02:20 PM, Shuah Khan wrote:
> On 11/12/2013 03:12 PM, Alexander Duyck wrote:
>> I think this might be overdoing the error checking by a bit.  I would
>> much rather have the DMA leaked error be visible than have it buried
>> under messages about the failure to check for DMA errors.  In my mind
>> the DMA buffer leak is much more serious than the failure to check for
>> mapping errors.
>>
>
> I agree DMA leak message is more important. Would you like to see just
> one message if mapping errors are found? Instead of printing the
> entire stacktrace like it does now, it could just do warn.
>
> -- Shuah
>
>

I think only one message would be preferred.  If nothing else you might
update the function so that it only dumps the DMA mapping error check on
the first one found and then goes quiet after that.  There is no point
in displaying the same error message multiple times since that is likely
what we would see.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/