lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Nov 2013 11:57:17 -0500 From: Benjamin LaHaise <bcrl@...ck.org> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Alexander Viro <viro@...iv.linux.org.uk>, linux-aio@...ck.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] aio: checking for NULL instead of IS_ERR On Wed, Nov 13, 2013 at 10:49:40AM +0300, Dan Carpenter wrote: > alloc_anon_inode() returns an ERR_PTR(), it doesn't return NULL. > > Fixes: 71ad7490c1f3 ('rework aio migrate pages to use aio fs') > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Thanks for spotting this. Acked-by: Benjamin LaHaise <bcrl@...ck.org> -ben > diff --git a/fs/aio.c b/fs/aio.c > index bf8d080..699f53e 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -164,8 +164,8 @@ static struct file *aio_private_file(struct kioctx *ctx, loff_t nr_pages) > struct file *file; > struct path path; > struct inode *inode = alloc_anon_inode(aio_mnt->mnt_sb); > - if (!inode) > - return ERR_PTR(-ENOMEM); > + if (IS_ERR(inode)) > + return ERR_CAST(inode); > > inode->i_mapping->a_ops = &aio_ctx_aops; > inode->i_mapping->private_data = ctx; -- "Thought is the essence of where you are now." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists