linux-kernel - Re: [PATCH] rcu: Make struct rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131113171205.GG4138@linux.vnet.ibm.com>
Date:	Wed, 13 Nov 2013 09:12:05 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] rcu: Make struct rcu_head searchable

On Wed, Nov 13, 2013 at 12:02:25PM -0500, Steven Rostedt wrote:
> After wasting too much time trying to see where struct rcu_head was
> declared, I finally found it in include/linux/types.h as a define for
> callback_head!
> 
> To prevent other developers from wasting their precious time in
> searching for this structure, add a comment to help them find it!
> 
> Cc: Al Viro <viro@...IV.linux.org.uk>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Steven "frustrated" Rostedt <rostedt@...dmis.org>

The cscope tool is your friend in this case, but nevertheless:

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> diff --git a/include/linux/types.h b/include/linux/types.h
> index 4d118ba..073e9a8 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -210,6 +210,9 @@ struct callback_head {
>  	struct callback_head *next;
>  	void (*func)(struct callback_head *head);
>  };
> +/*
> + * Make "struct rcu_head {" seachable with this comment.
> + */
>  #define rcu_head callback_head
> 
>  #endif /*  __ASSEMBLY__ */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/