linux-kernel - Re: [PATCH] mfd: syscon: Allow to using subdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 18:58:46 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Mark Rutland <mark.rutland@....com>
Cc:	linux-kernel@...r.kernel.org 
	<linux-kernel@...r.kernel.org>,
	devicetree@...r.kernel.org 
	<devicetree@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	grant.likely@...aro.org 
	<grant.likely@...aro.org>,
	rob.herring@...xeda.com 
	<rob.herring@...xeda.com>
Subject: Re: [PATCH] mfd: syscon: Allow to using subdevices

Hello.

> On Thu, Nov 14, 2013 at 12:52:03PM +0000, Alexander Shiyan wrote:
> > This patch adds support for using subdevices within syscon node.
> > Primary usage of this is describe all devices with same memory
> > region in one container.
> 
> I think if you need to do this, you should not be using syscon. What
> exactly is your use-case?
> 
> I don't like the idea of treating syscon like a bus or container in this
> fashion.

Let me first show the new syscon-based driver. After a while, I'm going
to provide it. It will use the current way of getting syscon, i.e. through
syscon_regmap_lookup_by_phandle().

> > Signed-off-by: Alexander Shiyan <shc_work@...l.ru>
> > ---
> >  drivers/mfd/syscon.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> > index 71841f9..6e9244a 100644
> > --- a/drivers/mfd/syscon.c
> > +++ b/drivers/mfd/syscon.c
> > @@ -152,6 +152,9 @@ static int syscon_probe(struct platform_device *pdev)
> >  
> >  	platform_set_drvdata(pdev, syscon);
> >  
> > +	if (of_platform_populate(dev->of_node, NULL, NULL, dev))
> > +		dev_warn(dev, "Fail to create subdevices\n");
> > +
> >  	dev_info(dev, "regmap %pR registered\n", res);
> >  
> >  	return 0;
> > -- 

---