linux-kernel - Re: [PATCH] drivers: scsi: lpfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5284EF2E.7010600@emulex.com>
Date:	Thu, 14 Nov 2013 10:41:34 -0500
From:	James Smart <james.smart@...lex.com>
To:	Felipe Pena <felipensp@...il.com>
CC:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment

Thanks!

Acked-by:   James Smart  <james.smart@...lex.com>

-- james s


On 10/18/2013 7:15 PM, Felipe Pena wrote:
> On lpfc_debugfs_initialize function the dumpHostSlim member setup happens
> when 'phba->sli_rev < LPFC_SLI_REV4' is true, however when it is false NULL
> has been assigned to debug_dumpHBASlim instead of debug_dumpHostSlim.
>
> Signed-off-by: Felipe Pena <felipensp@...il.com>
> ---
>   drivers/scsi/lpfc/lpfc_debugfs.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index 60084e6..b800cc9 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -4001,7 +4001,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
>   				goto debug_failed;
>   			}
>   		} else
> -			phba->debug_dumpHBASlim = NULL;
> +			phba->debug_dumpHostSlim = NULL;
>
>   		/* Setup dumpData */
>   		snprintf(name, sizeof(name), "dumpData");
> --
> 1.7.10.4
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/