linux-kernel - Re: [PATCH 6/9] KEYS: Trusted: Use key preparsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 15:50:59 +0000
From:	David Howells <dhowells@...hat.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	dhowells@...hat.com, d.kasatkin@...sung.com, zohar@...ibm.com,
	keyrings@...ux-nfs.org, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	David Safford <safford@...ux.vnet.ibm.com>
Subject: Re: [PATCH 6/9] KEYS: Trusted: Use key preparsing

Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:

> > - * trusted_instantiate - create a new trusted key
> > + * trusted_preparse - Preparse data for an trusted key
> >   *
> > - * Unseal an existing trusted blob or, for a new key, get a
> > - * random key, then seal and create a trusted key-type key,
> > - * adding it to the specified keyring.
> > + * Decrypt an existing encrypted datablob or create a new encrypted key
> > + * based on a kernel random number.
> 
> Not sure why the change in terminology from unsealing/trusted blob to
> decrypt/encrypted blob.

Because the "Unseal an existing trusted blob ..." bit is still attached to the
trusted_instantiate() function.  However, even what I wrote is still not a
good description of the trusted_preparse(), so I'll reduce it to just:

	/*
	 * trusted_preparse - Preparse the payload data for an trusted key
	 *
	 * On success, return 0. Otherwise return errno.
	 */

> trusted_preparse() always fails, since ret is initialized to -ENOMEM and
> never set.

Fixed.

Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/