linux-kernel - Re: [PATCH 12/40] staging/lustre/nfs: writing to new files will return ENOENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <048D09EB-A44F-422F-A88C-D26E93C9225C@xyratex.com>
Date:	Thu, 14 Nov 2013 08:22:34 -0800
From:	Cheng Shao <cheng_shao@...atex.com>
To:	Peng Tao <bergwolf@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Patrick Farrell <paf@...y.com>, Peng Tao <bergwolf@...il.com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 12/40] staging/lustre/nfs: writing to new files will return ENOENT

Hi Peng,

This patch was eventually reverted as it was causing interoperability issues with 2.1 Lustre server. We are working on the new patch, so please don't include this one.

Thanks,
- Cheng

> On Nov 14, 2013, at 8:13 AM, Peng Tao <bergwolf@...il.com> wrote:
> 
> From: Patrick Farrell <paf@...y.com>
> 
> This happend with SLES11SP2 Lustre client, which in turn acts as an
> NFS server, exporting a subtree of an Lustre fs through NFS.
> 
> We detected that whenever we are writing to a new file using, fx,
> 'echo blah > newfile', it will return ENOENT error. We found
> out that this was caused by the anonymous dentry. In SLESS11SP2,
> anonymous dentries are assigned '/' as the name, instead of an
> empty string. When MDT handles the intent_open call, it will look
> up the obj by the name if it is not an empty string, and thus
> couldn't find it.
> 
> As MDS_OPEN_BY_FID is always set on this request, we never need
> to send the name in this request.  The fid is already available
> and should be used in case the file has been renamed.
> 
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544
> Lustre-change: http://review.whamcloud.com/6920
> Signed-off-by: Cheng Shao <cheng_shao@...atex.com>
> Signed-off-by: Patrick Farrell <paf@...y.com>
> Reviewed-by: Bob Glossman <bob.glossman@...el.com>
> Reviewed-by: Alexey Shvetsov <alexxy@...too.org>
> Reviewed-by: Lai Siyao <lai.siyao@...el.com>
> Reviewed-by: James Simmons <uja.ornl@...il.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@...el.com>
> Signed-off-by: Peng Tao <bergwolf@...il.com>
> Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
> ---
> drivers/staging/lustre/lustre/llite/file.c |    5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index f97c600..efc614b 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -368,8 +368,6 @@ static int ll_intent_file_open(struct file *file, void *lmm,
> {
>    struct ll_sb_info *sbi = ll_i2sbi(file->f_dentry->d_inode);
>    struct dentry *parent = file->f_dentry->d_parent;
> -    const char *name = file->f_dentry->d_name.name;
> -    const int len = file->f_dentry->d_name.len;
>    struct md_op_data *op_data;
>    struct ptlrpc_request *req;
>    __u32 opc = LUSTRE_OPC_ANY;
> @@ -394,8 +392,9 @@ static int ll_intent_file_open(struct file *file, void *lmm,
>    }
> 
>    op_data  = ll_prep_md_op_data(NULL, parent->d_inode,
> -                      file->f_dentry->d_inode, name, len,
> +                      file->f_dentry->d_inode, NULL, 0,
>                      O_RDWR, opc, NULL);
> +
>    if (IS_ERR(op_data))
>        return PTR_ERR(op_data);
> 
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/