linux-kernel - Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131114182609.GB2133@thinkpad.fritz.box>
Date:	Thu, 14 Nov 2013 19:26:09 +0100
From:	Andreas Werner <wernerandy@....de>
To:	Joe Perches <joe@...ches.com>
Cc:	Marek Vasut <marex@...x.de>, wsa@...-dreams.de, jacmet@...site.dk,
	baohua.song@....com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] I2C: busses: Do not print error message in syslog if no
 ACK received

On Thu, Nov 14, 2013 at 05:39:52AM -0800, Joe Perches wrote:
> On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote:
> > > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote:
> > > > > > That is because if you look at the only caller of this function,
> > > > > > which is pch_i2c_wait_for_check_xfer(), you will see that at the
> > > > > > only place where pch_i2c_getack() is called there is already
> > > > > > pch_dbg():
> > > > > > 
> > > > > > 369         if (pch_i2c_getack(adap)) {
> > > > > > 370                 pch_dbg(adap, "Receive NACK for slave address"
> > > > > > 371                         "setting\n");
> > > > > > 372                 return -EIO;
> > > > > > 373         }
> > > 
> > > Sorry i misunderstood that. You are absolutly right, thats the best
> > > solution for that. Remove the pch_err at getack so that only the pch_dbg
> > > get printed where getack is called. This should be enough information.
> > 
> > No problem ;-)
> 
> If this is the approach taken, please coalesce the format.
> As is there's a missing space between address and setting.
> This should be:
> 
> 		pch_dbg(adap, "Received NACK for slave address setting\n");
> 
> 
Hi,
yes you are right, i will also add it and resand the patch in a few days.

regards 
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/