linux-kernel - Re: [PATCH] connector: improved unaligned access error fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131114124549.7b5f3a7b@lembas.zaitcev.lan>
Date:	Thu, 14 Nov 2013 12:45:49 -0700
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	Evgeniy Polyakov <zbr@...emap.net>, Erik Jacobson <erikj@....com>,
	Andrew Morton <akpm@...l.org>,
	Matt Helsley <matthltc@...ibm.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, zaitcev@...hat.com
Subject: Re: [PATCH] connector: improved unaligned access error fix

On Thu, 14 Nov 2013 12:09:21 -0500
Chris Metcalf <cmetcalf@...era.com> wrote:

> -	__u8 buffer[CN_PROC_MSG_SIZE];
> +	__u8 buffer[CN_PROC_MSG_SIZE] __aligned(8);

> -	msg = (struct cn_msg *)buffer;
> +	msg = buffer_to_cn_msg(buffer);
>  	ev = (struct proc_event *)msg->data;
>  	memset(&ev->event_data, 0, sizeof(ev->event_data));

Why is memset(buffer,0,CN_PROC_MSG_SIZE) not acceptable?

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/