linux-kernel - Re: [PATCH net] ip6tnl: fix use after free of fb_tnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131114.170529.1627250972818871118.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 17:05:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, gregkh@...uxfoundation.org,
	williams@...hat.com, linux-rt-users@...r.kernel.org,
	lclaudio@...g.org, netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net] ip6tnl: fix use after free of fb_tnl_dev

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu, 14 Nov 2013 15:47:03 +0100

> Bug has been introduced by commit bb8140947a24 ("ip6tnl: allow to use rtnl ops
> on fb tunnel").
> 
> When ip6_tunnel.ko is unloaded, FB device is delete by rtnl_link_unregister()
> and then we try to use the pointer in ip6_tnl_destroy_tunnels().
> 
> Let's add an handler for dellink, which will never remove the FB tunnel. With
> this patch it will no more be possible to remove it via 'ip link del ip6tnl0',
> but it's safer.
> 
> The same fix was already proposed by Willem de Bruijn <willemb@...gle.com> for
> sit interfaces.
> 
> CC: Willem de Bruijn <willemb@...gle.com>
> Reported-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied and queued up for -stable, thanks for being so proactive about this
Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/